Skip to content

Fix concurrent connections to room #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carne8 merged 10 commits into from
Jul 8, 2025
Merged

Fix concurrent connections to room #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c4e2660
Fix concurrent connections to room
carne8 Jul 7, 2025
751bf9b
Split signaling hub in files
carne8 Jul 8, 2025
d6f2489
Refactor ConnectToRoomPlayers
carne8 Jul 8, 2025
e9f7018
Renamed things
carne8 Jul 8, 2025
ea9c3ee
Replaced locks with semaphore
carne8 Jul 8, 2025
3692371
Add types tests
carne8 Jul 8, 2025
323bdfa
Add concurrency test for joining a room
carne8 Jul 8, 2025
8ef2360
Refactor tests
carne8 Jul 8, 2025
1191309
Remove room initiator
carne8 Jul 8, 2025
8f57b58
Add concurrency test for leaving a room
carne8 Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/Behide.OnlineServices.Tests/Behide.OnlineServices.Tests.fsproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,13 @@
<ProjectReference Include="../Behide.OnlineServices/Behide.OnlineServices.fsproj" />

<Compile Include="Common.fs" />
<Compile Include="Tests/Signaling.fs" />

<Compile Include="Tests\Types.fs" />

<Compile Include="Tests\Signaling\Common.fs" />
<Compile Include="Tests\Signaling\RoomManagement.fs" />
<Compile Include="Tests\Signaling\WebRTCSignaling.fs" />
<Compile Include="Tests\Signaling\Signaling.fs" />
<Compile Include="Program.fs" />
</ItemGroup>

Expand Down
15 changes: 5 additions & 10 deletions src/Behide.OnlineServices.Tests/Common.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,22 +10,17 @@ open Behide.OnlineServices
open Behide.OnlineServices.Signaling

let createTestServer () =
let offerStore = Hubs.Signaling.ConnAttemptStore()
let connectionAttemptStore = Hubs.Signaling.ConnectionAttemptStore()
let roomStore = Hubs.Signaling.RoomStore()
let playerConnStore = Hubs.Signaling.PlayerConnStore()
let playerConnStore = Hubs.Signaling.PlayerStore()

let hostBuilder =
WebHostBuilder()
.ConfigureServices(fun services ->
services |> Program.configureServices |> ignore

services.Remove(ServiceDescriptor.Singleton<Hubs.Signaling.IConnAttemptStore, Hubs.Signaling.ConnAttemptStore>()) |> ignore
services.Remove(ServiceDescriptor.Singleton<Hubs.Signaling.IRoomStore, Hubs.Signaling.RoomStore>()) |> ignore
services.Remove(ServiceDescriptor.Singleton<Hubs.Signaling.IPlayerConnStore, Hubs.Signaling.PlayerConnStore>()) |> ignore

services.AddSingleton<Hubs.Signaling.IConnAttemptStore>(offerStore) |> ignore
services.AddSingleton<Hubs.Signaling.IConnectionAttemptStore>(connectionAttemptStore) |> ignore
services.AddSingleton<Hubs.Signaling.IRoomStore>(roomStore) |> ignore
services.AddSingleton<Hubs.Signaling.IPlayerConnStore>(playerConnStore) |> ignore
services.AddSingleton<Hubs.Signaling.IPlayerStore>(playerConnStore) |> ignore
)
.Configure(fun app ->
app.UseRouting()
Expand All @@ -36,7 +31,7 @@ let createTestServer () =
)

new TestServer(hostBuilder),
offerStore :> Store.IStore<_, _>,
connectionAttemptStore :> Store.IStore<_, _>,
roomStore :> Store.IStore<_, _>,
playerConnStore :> Store.IStore<_, _>

Expand Down
Loading