chore(deps-dev): bump @types/node and eslint in /vscode-bino - #83
Open
ThatScalaGuy wants to merge 1 commit into
Open
chore(deps-dev): bump @types/node and eslint in /vscode-bino#83ThatScalaGuy wants to merge 1 commit into
ThatScalaGuy wants to merge 1 commit into
Conversation
Carries the safe subset of the npm-minor-patch group (dependabot #76): @types/node 25.9.1 -> 25.9.3 and eslint 10.4.1 -> 10.5.0. esbuild 0.28.1 already landed via #75. Drops the group's @types/vscode 1.85.0 -> 1.120.0 bump: 1.120.0 exceeds engines.vscode (^1.85.0), which makes `vsce package` fail at release time (the CI compile step does not catch this). Add a dependabot ignore for @types/vscode so it is not re-proposed until the minimum supported VS Code version is intentionally raised.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Carries the safe subset of the
npm-minor-patchgroup from dependabot #76:@types/node25.9.1 → 25.9.3eslint10.4.1 → 10.5.0esbuild0.28.1 already landed via #75.Why this instead of #76
#76 also bumped
@types/vscode1.85.0 → 1.120.0. That failsvsce packageat release time:The CI
VS Code Extensionjob only runsnpm run compile, so it doesn't catch this — butrelease.yml'sbuild-vscode-extensionjob runsvsce package, which the releaseneeds. Rather than raiseengines.vscode(which would lift the minimum supported VS Code version by ~35 releases), this keeps@types/vscodepinned at the engines floor and adds a dependabotignorefor it so the broken bump isn't re-proposed until we intentionally raise the minimum.dependabot auto-closed #76 after #75 merged, so this lands the remaining safe updates on a clean branch.
Verified locally:
npm ci,npm run compile, andvsce packageall succeed.