frontend: Clean up MAVLink refresh rates on leave (store + vehicle setup) - #4047
Open
joaoantoniocardoso wants to merge 2 commits into
Open
frontend: Clean up MAVLink refresh rates on leave (store + vehicle setup)#4047joaoantoniocardoso wants to merge 2 commits into
joaoantoniocardoso wants to merge 2 commits into
Conversation
4 tasks
|
@review.md |
joaoantoniocardoso
requested review from
Williangalvani,
joaomariolago,
nicoschmdt and
patrickelectric
July 27, 2026 22:36
joaoantoniocardoso
force-pushed
the
pr/mavlink-rate-cleanup
branch
from
July 28, 2026 01:34
e54d12b to
f0da846
Compare
Member
Could we do this instead? that would take some more code, but we wouldnt override other's rates |
Track per-message rate claims and apply max(claims) so consumers can lower streams on destroy without overriding other live subscribers.
joaoantoniocardoso
force-pushed
the
pr/mavlink-rate-cleanup
branch
from
July 30, 2026 23:01
f0da846 to
fbfd87e
Compare
joaoantoniocardoso
marked this pull request as draft
July 30, 2026 23:01
…leave Release message rate claims on destroy, discard position listeners, and clear the CompassDisplay render interval plus GSAP tweens.
joaoantoniocardoso
force-pushed
the
pr/mavlink-rate-cleanup
branch
from
July 31, 2026 00:41
fbfd87e to
a55d013
Compare
joaoantoniocardoso
marked this pull request as ready for review
July 31, 2026 22:32
Member
Author
Done; that's indeed a better approach, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max(claims)(idle 1 Hz) so one consumer can leave without overriding another.Test plan
Supersedes #4031 (recreated from fork
joaoantoniocardoso/BlueOS-dockerinstead of same-repo head).