[Backport] [A-1756] Apply request headers from streaming pings - #4275
[Backport] [A-1756] Apply request headers from streaming pings#4275moskyb wants to merge 1 commit into
Conversation
(cherry picked from commit c3ea8aa) Amp-Thread-ID: https://ampcode.com/threads/T-01a0412b-4df3-77cf-bdee-5cc9de145470 Co-authored-by: Amp <amp@ampcode.com>
![buildsworth-bk-app[bot]](https://avatars.githubusercontent.com/in/3010600?s=60&v=4){kind=small}
There was a problem hiding this comment.
I didn't find a concrete issue in the backport. It matches the merged v4 patch apart from the expected v3 package paths. Because it changes the streaming agent protocol and shard-routing handoff, I'm leaving approval to a human reviewer.
The agent CI status is failing; its job details weren't accessible from this review environment.
Want to dig deeper?
Paste this into your agent to explore the findings from this review's Buildkite build:
Download the buildsworth logs from build 21730, then answer my questions about the findings.
Install the reading-buildsworth-logs skill to run this.
About buildsworth
Model: gpt-5.6-sol with xhigh thinking.
How to request a review: Comment @buildsworth-bk review on the PR, or request buildsworth-bk as a reviewer.
Risk labels (how buildsworth classifies risk) — buildsworth classifies risk itself from the diff. Unless repository policy already allows L2 approval, grant it by mentioning @buildsworth-bk (see approval ceiling and L2 approval grant):
- L1 — Low risk (dep bumps, docs/copy, lockfiles, small presentational fixes). buildsworth may approve by default.
- L2 — Standard risk (new UI, additive API fields, refactors). Approved only when repository policy or a verified grant allows it; otherwise comment-only.
- L3 — High risk (auth, migrations, payments, secrets, perf-critical paths). Human review always required.
1 participant
Description
Backport of #4256 to
v3. It applies server-specified request header updates received from the ping stream and reconnects when the effective headers change.Context
See #4256 for the full description and investigation context.
Changes
The behaviour matches the merged v4 change. The generated protobuf descriptor retains Agent v3's
github.com/buildkite/agent/v3package path.Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go tool gofumpt -extra -w .)Disclosures / Credits
Prepared and validated with Amp as a v3 backport of the merged v4 change.