Skip to content

fix: update OIDC hooks and clear traits for registration flow #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
giriparus wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: update OIDC hooks and clear traits for registration flow #910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docker/kratos/kratos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,8 @@ selfservice:
- hook: session
oidc:
hooks:
- hook: session
- hook: show_verification_ui
- hook: session
webauthn:
hooks:
- hook: session
Expand Down
5 changes: 5 additions & 0 deletions pkg/kratos/service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1001,6 +1001,11 @@ func (s *Service) ParseRegistrationFlowMethodBody(r *http.Request) (*kClient.Upd
if err := parseBody(r.Body, &body); err != nil {
return nil, err
}
// Traits for OIDC registration must come from IdP-verified claims
// (docker/kratos/schema.jsonnet), never from client input. Without this,
// the identifier-first email (xxx@email.com) overrides the provider email
// (yyy@gmail.com) and the account registers under an unproven address.
body.Traits = nil
ret = kClient.UpdateRegistrationFlowWithOidcMethodAsUpdateRegistrationFlowBody(&body)
default:
return nil, fmt.Errorf("unknown method: %s", method)
Expand Down