fix: ship-hygiene dead pairings, evidence-gate check prefix, council ballot-file contract gap, bin quoting safety - #28
Merged
Conversation
…ballot-file contract gap, bin quoting safety Cycle 1: - ship-hygiene/SKILL.md: remove dead budget-mode and systematic-debugging pairings - evidence-gate/SKILL.md: fix bare 'check --gate' to include python3 <skill-dir>/scripts prefix - worklog/bin/.gitignore: add __pycache__/ to prevent stale .pyc noise Cycle 2: - council/SKILL.md: fix validate-ballot.py path for consistency (bin/ -> <skill-dir>/bin/) - council/SKILL.md: add step 6a to Recipe for explicit save-ballots-to-file before validation Cycle 3: - worklog/bin/refactor.sh: quote ALL_HITS in printf, for loop, and git add - worklog/bin/pre-commit-scan.sh: quote HITS to preserve secret-pattern output - worklog/bin/cache-purge.sh: quote HITS in printf display - worklog/bin/git-hooks/commit-msg: remove unused DRIFT variable - worklog/bin/project.sh: remove unused HB from local declaration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three cycles of targeted defect repair across the dotfiles skillset:
Cycle 1 — Dead references & contract drift
budget-modeandsystematic-debuggingpairing references (skills don't exist)check --gateinvocation to include fullpython3 <skill-dir>/scripts/evidence_gate.py check --gateprefix__pycache__/to prevent stale .pyc artifactsCycle 2 — Path consistency & procedural gaps
validate-ballot.pypath to use<skill-dir>/bin/(consistent with evidence-gate/loop-engineering patterns)Cycle 3 — Shell safety & dead code
ALL_HITSin printf, for loop, and git add (prevents word-splitting bugs with space-containing paths)HITSto preserve secret-pattern output format (security-critical warning was being garbled)HITSin printf displayDRIFTvariableHBfrom local declarationEvidence
Each cycle had a formal evidence-gate check with typed evidence records. All gate files preserved in
/tmp/dotfiles-skill-program-next/.