fix(worklog): propagate rg errors in search.sh instead of silently swallowing - #30
Merged
Merged
Conversation
…allowing The rg/xargs pipeline used 2>/dev/null || true, making rg errors (invalid regex, binary match failures) indistinguishable from genuine 'no hits' results. Capture stderr to a temp file and print it if non-empty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
search.shused2>/dev/null || trueon the rg/xargspipeline at line 206-207, making rg errors (invalid regex, file I/O failures, binary match problems) indistinguishable from genuine 'no hits' results. If rg failed, the caller got(no hits for /pattern/)— a misleading dead end.Fix: capture rg stderr to a temp file and print it to stderr if non-empty. Genuine 'no hits' still shows
(no hits for ...)and exits 1, but real errors are now surfaced.Validation
bash tests/run.sh all: 75 pass, 0 failWorklog-Slug: worklog-search-error-handling