dev/wordpress#62 Update adrienrn/php-mimetyper gitignore file to ensu… - #17853
Conversation
…re that sites that manage their systems using git can access the db.json file
|
(Standard links)
|
|
I can't think of any way to test this |
|
My logic is to have distmaker to create the tarballs with the PR applied. The extract and inspect the I've done this and it looks good. |
|
@kcristiano the problem with doing it via distmaker is that that only works for Drupal 7, WordPress, Joomla folks who manage using git, This doesn't solve it for those of us in D8 land who also manage our sites in git because composer will download from the source repo which has the problematic gitignore. Doing it this way ensures that it works for both D8 folks and also for distmaker because composer packages will apply this even in a d8 context |
|
@kcristiano please merge this when you are satisfied |
|
@kcristiano I think i have mistook your comment about dismaker please disregard mine I think Kevin is saying he has applied and confirmed it works is that correct? |
|
@seamuslee001 I apologize that was a bad comment. I created a 5.28 tarball (same as the one you linked to in the issue - I missed that) Added to my git repo via the build process and then pushed. The new This looks good to merge. |
|
Test fails unrelated merging |
…re that sites that manage their systems using git can access the db.json file
Overview
This updates the gitignore file as per adrienrn/php-mimetyper#15 I have tested this on a D8 build that we manage with git and confirm that i can now commit in the db.json file
Before
If you manage your site with git the db.json file gets missed
After
db.json file doesn't get missed
ping @kcristiano @eileenmcnaughton