DRAFT: Redirect URLs from WP mailings - #36460
Open
aydun wants to merge 2 commits into
Open
Conversation
|
🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷 Introduction for new contributors...
PR commands & links...
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Provide URL redirection so that mails sent from Civi on WP continue to work after migration to Standalone.
This reduces one of the points of friction when migrating to Standalone.
Background: https://chat.civicrm.org/civicrm/pl/ojd5d8kisjrd8nmr13qw97take
Before
After
Historic mails continue to work.
Technical Details
The first 2 of the redirections could be done at the webserver level - if your hosting provides capability to do that.
The mailing url ones need to look at the parameters.
These URL's are intentionally specific to those found in Mosaico mails, not a general redirection from WP.
The call to
self::wpredirect()could be gated behind a setting.This should be fairly safe from weirdly crafted URLs since it just does redirects.
Comments
Anything else you would like the reviewer to note