fix importing campaign/event ID on a contribution starting with a number - #36477
Open
MegaphoneJon wants to merge 1 commit into
Open
fix importing campaign/event ID on a contribution starting with a number#36477MegaphoneJon wants to merge 1 commit into
MegaphoneJon wants to merge 1 commit into
Conversation
|
🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷 Introduction for new contributors...
PR commands & links...
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
If you have a campaign or event whose title starts with a number e.g. "26FY donations", and you import a contribution using that title, it will be treated as a campaign ID (in this case, 26) if that campaign ID is found first.
It appears that events have the same issue.
You can replicate this by creating a new campaign starting with 1, e.g. "1 test". Import a contribution with the Campaign column set to
1 test.Before
Campaign titles imported as if they're IDs.
After
Only numeric values are searched by ID.
Technical Details
This has to do with how MySQL casts the value, but we should fix this at the import layer, not the API/db layer.