Note - Ensure form redirect works for delete action - #36501
Open
colemanw wants to merge 1 commit into
Open
Conversation
Before: Form would redirect on save but not delete After: Works consistently
|
🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷 Introduction for new contributors...
PR commands & links...
|
| } | ||
|
|
||
| // store the submitted values in an array | ||
| $params = $this->controller->exportValues($this->_name); |
Contributor
There was a problem hiding this comment.
@colemanw given we are tidying this up i think that this should be $this->getSubmittedValues() right @eileenmcnaughton ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Followup fix for #36495
Before
Form would redirect on save but not delete
After
Works consistently