Submission API: Enforce phase start/end window on submission creation - #2496
Open
ihsaan-ullah wants to merge 1 commit into
Open
Submission API: Enforce phase start/end window on submission creation#2496ihsaan-ullah wants to merge 1 commit into
ihsaan-ullah wants to merge 1 commit into
Conversation
Phase.is_active returned True unconditionally when end was unset, never checking start — a not-yet-started phase with no end date was treated as active. SubmissionCreationSerializer.validate() also never checked is_active or can_user_make_submissions(), so submissions could be created via the API before a phase started or after it ended. - Fix Phase.is_active to check start regardless of whether end is set - Reject submission creation when the target phase is not active or the user has hit their submission limit, returning a 400 error - Add tests for both new fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Phase.is_active returned True unconditionally when end was unset, never checking start — a not-yet-started phase with no end date was treated as active. SubmissionCreationSerializer.validate() also never checked is_active or can_user_make_submissions(), so submissions could be created via the API before a phase started or after it ended.
Issues this PR resolves
Any relevant files for testing
CODABENCH_USERNAMEandCODABENCH_PASSWORDBASE_URL,COMPETITION_ID,PHASE_IDandSUBMISSION_FILEin `config.pypyton3 submission.pyto upload a submissionauth.py
config.py
submission.py
A checklist for hand testing
Checklist