chore(billing): improve notifications - #675
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves billing-related Telegram notifications by correcting mislabeled identifiers, consistently including workspace identity (name + id), and enriching CloudPayments failure diagnostics with Reason/ReasonCode context.
Changes:
- Updated billing Telegram messages to include
workspace: «name» (id)instead of only an id label. - Enhanced CloudPayments
/failhandling to log/emitReason+ReasonCodedetails and include them in Telegram alerts. - Fixed
/recurrentTelegram alert labeling by showing workspace identity (via subscription lookup) and explicitly labelingAccountIdasuser id.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/resolvers/billingNew.ts | Updates compose-payment Telegram message to include workspace name + id. |
| src/billing/cloudpayments.ts | Adds a workspace formatter helper and enriches Telegram/error logs for pay/fail/recurrent notifications. |
| package.json | Bumps package version from 1.5.8 to 1.5.9. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
workspace idlabel in /recurrent Telegram alerts. Previouslyuser idwas passed in therereason+ReasonCodelogs (e.g. NotAccepted (3008))