Retake the screenshots for 1.10.2 - #58
Merged
Merged
Conversation
A card lifted out on its own says nothing about which of the four pages it lives on, and for the first card of a page that is the information the picture exists to give. Save-TopCrop therefore keeps everything above it — logo, version, navigation, language switch — at the full width of the page. Which pages get that is a list, currently only the dashboard. The count check now warns only when there are fewer cards than names: more is deliberate, since a page may name only the first few.
Both languages, with the game identification visible: a running Steam title resolves to its platform and app id under the game tile, and the data-capture page carries the new option with its alpha and internet markers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pictures in the handbook still showed an older version and none of the game identification. Retaken with
tools/screenshots.ps1against a running 1.10.2, both languages, then compressed.One new picture
dashboard-status.png— the status card together with the header above it: logo, version, node name, navigation, language switch, at the full width of the page.A card lifted out on its own says nothing about which of the four pages it lives on, and for the first card of a page that is the information the picture exists to give. Which pages get that treatment is a list in the script; only the dashboard is on it. The count check now warns when there are fewer cards than names rather than on any mismatch — more is deliberate when a page names only its first few.
What they now show
A Steam title was running while they were taken, so the game tile carries
steam · 2183900with the app id linked, and the data-capture page shows the new option with its alpha and internet markers. 48 images, 1.43 MB after compression.