Open api union types - #35
Open
tomasvanrijsse wants to merge 2 commits into
Open
Conversation
Support composite OpenAPI types by generating PHP 8.1+ union types for DTOs. This enables better type accuracy for flexible API schemas that use anyOf, oneOf, or allOf constructs. Changes: - Added handleCompositeType() to process composite type schemas - Extract PHP types from References and inline Schemas - Support nested unions (e.g., anyOf with type: ["string", "null"]) - Generate FQN for referenced DTOs in union types - Deduplicate types in generated unions Code quality improvements: - Extracted buildDtoFqn() helper for DRY - Extracted extractTypeFromSchema() for type resolution - Added PHPDoc annotations - Fixed typo in mapType() (int64\t → int64) - Use strict comparison operators (===) - Fixed missing format parameter in array union handling Example output: BusinessId|null, Timestamp|null, DiscountSubscription|null Related to Phase 1, PR crescat-io#3 of generator improvements. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Verify that anyOf composite types correctly generate PHP union types for both primitive types (string|int|null) and DTO references. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support composite OpenAPI types by generating PHP 8.1+ union types for DTOs. This enables better type accuracy for flexible API schemas that use anyOf, oneOf, or allOf constructs.
Changes:
Example output: BusinessId|null, Timestamp|null, DiscountSubscription|null