Do not mix chef calls and proposal saves - #255
Open
dirkmueller wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
unexpected token tIDENTIFIER
(Using Ruby 2.3 parser; configure using TargetRubyVersion parameter, under AllCops)
dirkmueller
force-pushed
the
proposal_untangle
branch
from
January 29, 2016 11:04
eb46335 to
34ecb1b
Compare
There was a problem hiding this comment.
Style/SpaceAfterComma: Space missing after comma. (https://github.com/bbatsov/ruby-style-guide#spaces-operators)
Member
|
I don't understand. Does doing something like |
dirkmueller
force-pushed
the
proposal_untangle
branch
from
January 29, 2016 11:14
34ecb1b to
37beb74
Compare
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. 105/100
dirkmueller
force-pushed
the
proposal_untangle
branch
from
January 29, 2016 11:16
37beb74 to
fddfe17
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using chef calls while the propsal is still being modified
can cause delays that would cause the transaction to be delayed
so long that other workers get a busy exception. Shorten the lifetime
of the critical section.