Fix kernel update issue if version is different, release is the same - #10
Merged
Conversation
This doesn't come up in EL kernels, but is a problem for custom kernels. Signed-off-by: Jonathan Dieter <jdieter@ciq.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where kernel updates were incorrectly blocked when custom kernels had different versions but the same release number (e.g., 5.10.0-1 vs 5.10.1-1). The fix ensures that packages built from the same kernel source RPM are properly identified by filtering on both version and release, rather than just release alone.
Changes:
- Updated two filter() calls in
src/protected_kmods.pyto filter by both version and release instead of just release - Bumped version to 1.0.1 and added changelog entry in the spec file
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/protected_kmods.py | Added version parameter to two filter() calls that assemble lists of packages from the same kernel source RPM, ensuring accurate filtering when version differs but release is the same |
| dnf-plugin-protected-kmods.spec | Version bump to 1.0.1 and added changelog entry documenting the fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
juphoff
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn't come up in EL kernels, but is a problem for custom kernels.