Add documentation making it clear where this code originated - #8
Merged
Conversation
Signed-off-by: Jonathan Dieter <jdieter@ciq.com>
There was a problem hiding this comment.
Pull Request Overview
Adds documentation clarifying the plugin’s origin, updates version metadata, and provides instructions for generating plain-text docs.
- Introduces a header and origin attribution in
protected_kmods.py - Bumps the plugin version to 0.9.5 and updates the changelog in the spec file
- Adds build instructions and a history section to both
README.mdand the plain-textREADME
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/protected_kmods.py | Added comment block with plugin name and fork origin |
| dnf-plugin-protected-kmods.spec | Updated Version and Changelog entries for 0.9.5-1 |
| README.md | Added plain-text build instructions and “History” section |
| README | Mirrored build instructions and “History” in the generated file |
Comments suppressed due to low confidence (1)
MatthewHink
reviewed
Jul 8, 2025
|
|
||
|
|
||
| %changelog | ||
| * Mon Jun 16 2025 Jonathan Dieter <jdieter@ciq.com> - 0.9.4-1 |
There was a problem hiding this comment.
Silly question. Is this clobbering an old changelog?
Collaborator
Author
There was a problem hiding this comment.
It is because the request is that the changelog starts from when the package enters the EPEL repository.
There was a problem hiding this comment.
Cool this way was deliberate. Thank you for helping me understand.
MatthewHink
approved these changes
Jul 8, 2025
|
|
||
|
|
||
| %changelog | ||
| * Mon Jun 16 2025 Jonathan Dieter <jdieter@ciq.com> - 0.9.4-1 |
There was a problem hiding this comment.
Cool this way was deliberate. Thank you for helping me understand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.