Skip to content

Pin GitHub Actions to SHAs [SRE-1802] - #52

Merged
wresch merged 1 commit into
mainfrom
sre-1802-pin-actions-to-shas
May 29, 2026
Merged

Pin GitHub Actions to SHAs [SRE-1802]#52
wresch merged 1 commit into
mainfrom
sre-1802-pin-actions-to-shas

Conversation

@tylergohl

@tylergohl tylergohl commented May 21, 2026

Copy link
Copy Markdown
Contributor

Summary

Pin GitHub Actions references in this repo to immutable commit SHAs (with the original tag/branch preserved in a trailing comment).

Scope

This PR pins:

  • Internal ctrliq/* reusable workflow and action references
  • External actions

Files touched

  • .github/workflows/build.yml

Test plan

  • Workflow runs succeed on this branch (or on next trigger after merge)
  • Once this and any companion clo-ciq PR merge, this repo has zero unpinned external/internal refs and sha_pinning_required can be enabled on it

Copilot AI review requested due to automatic review settings May 21, 2026 01:54
@ciq-it-service-account

ciq-it-service-account commented May 21, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR hardens the CI supply chain by pinning GitHub Actions used in the repository’s workflow to immutable commit SHAs (per SRE-1802), reducing the risk of upstream tag changes affecting builds.

Changes:

  • Pin actions/setup-java references to a specific commit SHA (with v5 noted in comments).
  • Pin ncipollo/release-action to a specific commit SHA (with v1 noted in comments).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@wresch
wresch marked this pull request as ready for review May 29, 2026 18:03
@wresch
wresch requested a review from a team as a code owner May 29, 2026 18:03

@wresch wresch left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wresch
wresch merged commit 0716966 into main May 29, 2026
7 checks passed
@wresch
wresch deleted the sre-1802-pin-actions-to-shas branch May 29, 2026 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants