dart: Add implementation - #444
Conversation
…r dependency installation, analysis, and testing
…sions, including installation instructions, usage examples, and custom parameter types.
…tion, documentation link, funding sources, and relevant topics for better visibility and clarity.
…checks with a dedicated _isWhitespace method using a regex pattern for improved Unicode support.
…r overview of Cucumber Expressions for Dart, including syntax reference, usage examples, and features related to parameter type matching and expression generation.
…d consistency, removing unnecessary 'show' clauses while maintaining functionality.
…de and improve maintainability.
…ad of an interface, simplifying the implementation in ParameterTypeRegistry.
…y for creating expressions, enhancing clarity in README, and improving parameter type lookup mechanisms. Update tests to reflect changes in expression generation and matching.
…new js package and version adjustments for existing dependencies
…update related dependencies in pubspec.lock
…e README with usage examples
…ove code clarity and maintainability.
…er expressions and regular expressions, enhancing test coverage and ensuring compliance with expected behavior.
… test files for better readability and consistency.
…art implementation of Cucumber Expressions in the unreleased section
Updated the float regular expression for better accuracy and added tests to ensure that incomplete float representations are correctly rejected.
|
@Fried-man are you going to use this anywhere? I was happy to take the PRs for messages and gherkin because we already had a Gherkin implementation that needed them, but I'd rather not add or maintain code that won't be used by any one. |
I'd like to build out a Cucumber Dart/Flutter solution. I'm curious what your appetite for an official version is. |
|
I would also like to use this in Varar. I can see @mpkorstanje's point. The maintenance burden ends up being quite big for the Cucumber team. I think the ideal situation would be that whoever can build and maintain a port of Cucumber Expressions and maintain it outside this repo, while still being able to verify that it passes an official test suite. Currently the test suite consists of a corpus in ./testdata - plus additional unit tests ported from other languages. If I were to write another implementation (say, in Zig), I would keep it in a separate repo, and have a script that copied WDYT? |
|
Okay. That's two potential users. Good enough for me for now. @aslakhellesoy it is a shame we never setup Gherkin as an RFC + ENBF + test data. We could have published that as an artifact to derive other implementations from. That pattern would have carried over nicely to cucumber-expressions too. @Fried-man please request a review when ready. |
Co-authored-by: Cursor <cursoragent@cursor.com>
… root contributing guide
…ion` classes to expose compiled regular expressions.
…cumber expressions
…r and Regular expressions
3 participants
🤔 What's changed?
Created the dart implementation for Cucumber Expressions.
⚡️ What's your motivation?
Want to use Cucumber Expressions within a Cucumber Dart/Flutter solution.
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
General concerns about API surface.
Should I expose
CucumberExpression,RegularExpression, and the AST types in the barrel file? ShouldParameterTypeRegistry.parameterTypes,lookupByTypeName, andlookupByRegexpbe public?📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.