fix(php): clear both quarantined test groups, and the dead code they were hiding

.github/workflows/ci.yml

@@ -80,10 +80,15 @@ jobs:
         # in the default ./tests, which in this repo holds unrelated CLI
         # fixtures. Without it nothing is bound and every test errors.
         #
-        # continue-on-error while the suite is brought up: as of 2026-08-01 it
-        # runs 1302 tests, 993 passing and 303 failing — the failures are real
-        # and tracked (Livewire view stubs, the missing Core\Mcp dependency
-        # trait), not flakes. Drop this flag once the count reaches zero.
+        # continue-on-error while the suite is brought up: as of 2026-08-08 it
+        # runs 1311 tests, 1155 passing and 156 failing, with nothing skipped or
+        # excluded. The failures are real and tracked, not flakes — the largest
+        # remaining groups are the Core\Mcp tools (Core\Mcp\Tools\Concerns\
+        # ValidatesDependencies and Core\Mcp\Dependencies\HasDependencies live in
+        # dappcore/mcp, which is not a dependency here and collides with this
+        # package's own Core\Mcp\ PSR-4 root), the admin Livewire view stubs, and
+        # tests that reach a live Qdrant or Elasticsearch. Drop this flag once
+        # the count reaches zero.
         continue-on-error: true
         run: ./vendor/bin/pest --test-directory=php/tests --coverage --coverage-clover=coverage.xml
       - name: Upload PHP coverage to Codecov

composer.json

@@ -14,6 +14,7 @@
         "spatie/laravel-activitylog": "^4.8"
     },
     "require-dev": {
+        "dappcore/php-content": "^0.1",
         "dappcore/php-tenant": "^0.1",
         "laravel/pint": "^1.18",
         "livewire/livewire": "^3.0",

php/Console/Commands/GenerateCommand.php

@@ -7,10 +7,12 @@
 namespace Core\Mod\Agentic\Console\Commands;
 
 use Core\Mod\Agentic\Models\AgentPlan;
+use Core\Mod\Content\Jobs\GenerateContentJob;
+use Core\Mod\Content\Models\AIUsage;
+use Core\Mod\Content\Models\ContentBrief;
+use Core\Mod\Content\Services\AIGatewayService;
 use Illuminate\Console\Command;
-use Mod\Content\Jobs\GenerateContentJob;
-use Mod\Content\Models\ContentBrief;
-use Mod\Content\Services\AIGatewayService;
+use Illuminate\Support\Str;
 
 class GenerateCommand extends Command
 {
@@ -104,7 +106,7 @@ protected function generateBrief(): int
         // Create brief
         $brief = ContentBrief::create([
             'title' => $title,
-            'slug' => \Illuminate\Support\Str::slug($title),
+            'slug' => Str::slug($title),
             'content_type' => $this->option('type'),
             'service' => $this->option('service'),
             'keywords' => $this->option('keywords')
@@ -268,7 +270,7 @@ protected function generateFromPlan(): int
                 // Create brief from task
                 $brief = ContentBrief::create([
                     'title' => $taskName,
-                    'slug' => \Illuminate\Support\Str::slug($taskName).'-'.time(),
+                    'slug' => Str::slug($taskName).'-'.time(),
                     'content_type' => $this->option('type'),
                     'service' => $this->option('service') ?? ($plan->metadata['service'] ?? null),
                     'target_word_count' => (int) $this->option('words'),
@@ -333,7 +335,7 @@ protected function showQueueStats(): int
         $this->newLine();
         $this->line(' <comment>AI Usage (This Month):</comment>');
 
-        $usage = \Mod\Content\Models\AIUsage::thisMonth()
+        $usage = AIUsage::thisMonth()
             ->selectRaw('provider, SUM(input_tokens) as input, SUM(output_tokens) as output, SUM(cost_estimate) as cost')
             ->groupBy('provider')
             ->get();

php/Jobs/BatchContentGeneration.php

@@ -4,13 +4,13 @@
 
 namespace Core\Mod\Agentic\Jobs;
 
+use Core\Mod\Content\Models\ContentTask;
 use Illuminate\Bus\Queueable;
 use Illuminate\Contracts\Queue\ShouldQueue;
 use Illuminate\Foundation\Bus\Dispatchable;
 use Illuminate\Queue\InteractsWithQueue;
 use Illuminate\Queue\SerializesModels;
 use Illuminate\Support\Facades\Log;
-use Mod\Content\Models\ContentTask;
 
 class BatchContentGeneration implements ShouldQueue
 {

php/Jobs/ProcessContentTask.php

@@ -5,13 +5,13 @@
 namespace Core\Mod\Agentic\Jobs;
 
 use Core\Mod\Agentic\Services\AgenticManager;
+use Core\Mod\Content\Models\ContentTask;
 use Core\Tenant\Services\EntitlementService;
 use Illuminate\Bus\Queueable;
 use Illuminate\Contracts\Queue\ShouldQueue;
 use Illuminate\Foundation\Bus\Dispatchable;
 use Illuminate\Queue\InteractsWithQueue;
 use Illuminate\Queue\SerializesModels;
-use Mod\Content\Models\ContentTask;
 use Throwable;
 
 class ProcessContentTask implements ShouldQueue
@@ -51,7 +51,12 @@ public function handle(
             $result = $entitlements->can($workspace, 'ai.credits');
 
             if ($result->isDenied()) {
-                $this->task->markFailed("Entitlement denied: {$result->message}");
+                // getMessage(), not ->message: EntitlementResult carries the text
+                // as a readonly $reason and exposes it through getMessage(). There
+                // is no $message property and no __get, so this interpolated an
+                // undefined property and every denial was recorded with an empty
+                // reason.
+                $this->task->markFailed("Entitlement denied: {$result->getMessage()}");
 
                 return;
             }
@@ -111,7 +116,10 @@ public function failed(Throwable $exception): void
     private function interpolateVariables(string $template, array $data): string
     {
         foreach ($data as $key => $value) {
-            $placeholder = '{{{'.$key.'}}}';
+            // Two braces, not three. Every prompt template in the package writes
+            // {{name}}, so the three-brace placeholder never matched anything and
+            // user templates reached the provider with their variables intact.
+            $placeholder = '{{'.$key.'}}';
 
             if (is_string($value)) {
                 $template = str_replace($placeholder, $value, $template);

php/Agentic/Livewire/BrainExplorer.php → php/Livewire/BrainExplorer.php

@@ -300,6 +300,6 @@ private function normaliseMemory(array|BrainMemory $memory): array
      */
     protected function viewPath(): string
     {
-        return __DIR__.'/../../resources/views/livewire/agentic/brain-explorer.blade.php';
+        return __DIR__.'/../resources/views/livewire/agentic/brain-explorer.blade.php';
     }
 }

php/Agentic/Livewire/CreditLedger.php → php/Livewire/CreditLedger.php

@@ -286,6 +286,6 @@ private function syncSelectedAgentId(): void
      */
     protected function viewPath(): string
     {
-        return __DIR__.'/../../resources/views/livewire/agentic/credit-ledger.blade.php';
+        return __DIR__.'/../resources/views/livewire/agentic/credit-ledger.blade.php';
     }
 }

php/Agentic/Livewire/FleetOverview.php → php/Livewire/FleetOverview.php

@@ -299,6 +299,6 @@ private function summariseBudget(array $budget): string
      */
     protected function viewPath(): string
     {
-        return __DIR__.'/../../resources/views/livewire/agentic/fleet-overview.blade.php';
+        return __DIR__.'/../resources/views/livewire/agentic/fleet-overview.blade.php';
     }
 }

php/Agentic/Livewire/HubComponent.php → php/Livewire/HubComponent.php

@@ -19,7 +19,7 @@
  *   {
  *       protected function viewPath(): string
  *       {
- *           return __DIR__.'/../../resources/views/livewire/agentic/fleet-overview.blade.php';
+ *           return __DIR__.'/../resources/views/livewire/agentic/fleet-overview.blade.php';
  *       }
  *   }
  */

php/Mcp/Resources/ContentResource.php

@@ -6,11 +6,11 @@
 
 namespace Core\Mcp\Resources;
 
+use Core\Mod\Content\Models\ContentItem;
 use Core\Tenant\Models\Workspace;
 use Laravel\Mcp\Request;
 use Laravel\Mcp\Response;
 use Laravel\Mcp\Server\Resource;
-use Mod\Content\Models\ContentItem;
 use Symfony\Component\Yaml\Yaml;
 
 // Not final: resolveWorkspace / resolveContentItem / listResources are

php/Mcp/Tools/Agent/Content/ContentBatchGenerate.php

@@ -5,8 +5,8 @@
 namespace Core\Mod\Agentic\Mcp\Tools\Agent\Content;
 
 use Core\Mod\Agentic\Mcp\Tools\Agent\AgentTool;
-use Mod\Content\Jobs\GenerateContentJob;
-use Mod\Content\Models\ContentBrief;
+use Core\Mod\Content\Jobs\GenerateContentJob;
+use Core\Mod\Content\Models\ContentBrief;
 
 /**
  * Queue multiple briefs for batch content generation.

php/Mcp/Tools/Agent/Content/ContentBriefCreate.php

@@ -6,9 +6,9 @@
 
 use Core\Mod\Agentic\Mcp\Tools\Agent\AgentTool;
 use Core\Mod\Agentic\Models\AgentPlan;
+use Core\Mod\Content\Enums\BriefContentType;
+use Core\Mod\Content\Models\ContentBrief;
 use Illuminate\Support\Str;
-use Mod\Content\Enums\BriefContentType;
-use Mod\Content\Models\ContentBrief;
 
 /**
  * Create a content brief for AI generation.

php/Mcp/Tools/Agent/Content/ContentBriefGet.php

@@ -5,8 +5,8 @@
 namespace Core\Mod\Agentic\Mcp\Tools\Agent\Content;
 
 use Core\Mod\Agentic\Mcp\Tools\Agent\AgentTool;
-use Mod\Content\Enums\BriefContentType;
-use Mod\Content\Models\ContentBrief;
+use Core\Mod\Content\Enums\BriefContentType;
+use Core\Mod\Content\Models\ContentBrief;
 
 /**
  * Get details of a specific content brief including generated content.

php/Mcp/Tools/Agent/Content/ContentBriefList.php

@@ -5,8 +5,8 @@
 namespace Core\Mod\Agentic\Mcp\Tools\Agent\Content;
 
 use Core\Mod\Agentic\Mcp\Tools\Agent\AgentTool;
-use Mod\Content\Enums\BriefContentType;
-use Mod\Content\Models\ContentBrief;
+use Core\Mod\Content\Enums\BriefContentType;
+use Core\Mod\Content\Models\ContentBrief;
 
 /**
  * List content briefs with optional status filter.

php/Mcp/Tools/Agent/Content/ContentFromPlan.php

@@ -6,10 +6,10 @@
 
 use Core\Mod\Agentic\Mcp\Tools\Agent\AgentTool;
 use Core\Mod\Agentic\Models\AgentPlan;
+use Core\Mod\Content\Enums\BriefContentType;
+use Core\Mod\Content\Jobs\GenerateContentJob;
+use Core\Mod\Content\Models\ContentBrief;
 use Illuminate\Support\Str;
-use Mod\Content\Enums\BriefContentType;
-use Mod\Content\Jobs\GenerateContentJob;
-use Mod\Content\Models\ContentBrief;
 
 /**
  * Create content briefs from plan tasks and queue for generation.

php/Mcp/Tools/Agent/Content/ContentGenerate.php

@@ -5,9 +5,9 @@
 namespace Core\Mod\Agentic\Mcp\Tools\Agent\Content;
 
 use Core\Mod\Agentic\Mcp\Tools\Agent\AgentTool;
-use Mod\Content\Jobs\GenerateContentJob;
-use Mod\Content\Models\ContentBrief;
-use Mod\Content\Services\AIGatewayService;
+use Core\Mod\Content\Jobs\GenerateContentJob;
+use Core\Mod\Content\Models\ContentBrief;
+use Core\Mod\Content\Services\AIGatewayService;
 
 /**
  * Generate content for a brief using AI pipeline.