docs: name the 110 tests that cannot pass here, and who owns them - #12
Conversation
110 of the Module suite's failures are not defects in this package. They are
tests referencing classes owned by other packages — and every one of those
packages already requires dappcore/php:
dappcore/php-tenant requires dappcore/php: *
dappcore/agent requires dappcore/php: *
So no dependency could make them pass here. They cannot be fixed inside this
repository by any amount of work; they need to move to the repository that owns
what they test. Naming them is the only useful thing this repo can do with them,
which is what docs/misfiled-tests.md does — by owner, by file, with counts.
php-tenant 82 failures, 13 files Core\Tenant\Models\User (78),
Core\Tenant\Rules\ResourceStatusRule (4)
agent 25 failures, 1 file and wrong twice: it names
Core\Agentic\Services\AgentDetection,
while the class lives at
Core\Mod\Agentic\Services — a namespace
the ecosystem has moved away from, in a
package that cannot be depended on from
here. Fixing the namespace alone would
not make it pass.
host.uk.com 3 failures, 1 file Website\Host\Mail\ContactFormSubmission
lives in the application, not in any
package. A framework package testing its
consumer's mailable.
Most of the php-tenant ones want a User only to authenticate a request, and the
note says so: where that is all they need, a fixture user this package owns is
cheaper than moving the file. Where the test genuinely exercises tenancy, it
belongs in php-tenant. That distinction is theirs to make, not mine to guess.
The module-debt job's comment now points at the document rather than repeating a
summary that would drift from it.
No code changed. No test moved or deleted — deleting them here would erase the
findings their owners need.
python3 yaml.safe_load .github/workflows/tests.yml valid
vendor/bin/pint --test pass
Co-Authored-By: Virgil <virgil@lethean.io>
|
Warning Review limit reached
Next review available in: 46 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
110 of the Module suite's failures are not defects in this package. They are tests referencing classes owned by other packages — and every one of those packages already requires
dappcore/php:So no dependency could make them pass here. They cannot be fixed inside this repository by any amount of work — they need to move to the repository that owns what they test. Naming them is the only useful thing this repo can do with them.
By owner
dappcore/php-tenantCore\Tenant\Models\User(78),Core\Tenant\Rules\ResourceStatusRule(4)dappcore/agentCore\Agentic\Services\AgentDetection,Core\Agentic\Support\AgentIdentityWebsite\Host\Mail\ContactFormSubmissionThe agent one is wrong twice. It names
Core\Agentic\Services\AgentDetection, while the class actually lives atCore\Mod\Agentic\Servicesindappcore/agent— a namespace the ecosystem has moved away from, in a package that cannot be depended on from here. Correcting the namespace alone would not make it pass.The host.uk.com one has no possible fix here at all.
Website\Host\Mail\ContactFormSubmissionlives in the application (app/Website/Host/Mail/), not in any package. A framework package testing its consumer's mailable.A judgement left to their owners
Most of the php-tenant cases want a
Useronly to authenticate a request. Where that is all they need, a fixture user this package owns is cheaper than moving the file; where the test genuinely exercises tenancy, it belongs inphp-tenant. The note says so and stops there — that distinction is theirs to make, not mine to guess.What this changes
Nothing executable. No code, no test moved, no test deleted — deleting them here would erase the findings their owners need, and the count would improve while the information was destroyed.
The
module-debtjob's comment now points atdocs/misfiled-tests.mdrather than repeating a summary that would drift from it.🤖 Generated with Claude Code
Co-Authored-By: Virgil virgil@lethean.io