chore: normalize stdlib copy imports to import copy#1509
Open
dimitri-yatsenko wants to merge 1 commit into
Open
chore: normalize stdlib copy imports to import copy#1509dimitri-yatsenko wants to merge 1 commit into
import copy#1509dimitri-yatsenko wants to merge 1 commit into
Conversation
Three modules used three conventions for the copy module: diagram.py `import copy as copy_module`, settings.py `from copy import deepcopy`, expression.py `import copy`. Standardize on plain `import copy` with qualified `copy.deepcopy` / `copy.copy` — one import covers both shallow and deep copies, and the diagram.py alias was unnecessary (`copy` there only appears as a keyword argument, which can't collide with the module name). No behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standardizes how the stdlib
copymodule is imported across the codebase. Three modules used three conventions:diagram.py—import copy as copy_module→import copy(the alias was unnecessary;copyonly appears there as a keyword argument, which can't collide with the module name)settings.py—from copy import deepcopy→import copy, call-sites qualified ascopy.deepcopyexpression.py— alreadyimport copy(usescopy.copy); unchangedNow uniform:
import copywith qualifiedcopy.deepcopy/copy.copy, so one import covers both shallow and deep copies. Pure rename — no behavior change (identifiers only; ruff/isort/mypy clean, imports verified). Split out of #1508.