Log to a file in release builds instead of the system oslog - #3268
Open
trufae wants to merge 2 commits into
Open
Log to a file in release builds instead of the system oslog#3268trufae wants to merge 2 commits into
trufae wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
following for #3263
The idea here is that release builds will use a custom logger that just save the logs inside the app home, these files are not accessible from outside the app and are protected by the sandbox.
Also, i have enforced the files to not be backuped or saved in the icloud. i think that we shuold be careful about doing that with other files...because me as a user i wont like to backup/restore anything but the profile credentials.. but that's another topic outside the scope of this pr.
The new code have 2 logger implementations
im open to discussion about the strategy to rotate logs too,but i hope this appraoch fits better
PD: users must be warned not to share the logs as verbatim without review/redacted because it can include sensitive information. this message must be appearing somewhere around the "View Logs" button.