ci: release-smoke - run smoke checks as real JUnit @Test methods#89
Merged
Conversation
exec:exec ran everything through one main() method: if the first check threw, every check after it silently never ran. Split it into 16 independent @test methods (junit-jupiter, moved to src/test/java) so `mvn test` reports each one separately via Surefire's standard "Tests run: X, Failures: 0" summary, and one failing check no longer hides the rest. --enable-native-access=ALL-UNNAMED moves from a java command line flag to Surefire's argLine. Also add a Duration column to the results table (started_at/ completed_at from the Actions API), so slow legs are visible without opening each job. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exec:execmain() method into 16 independent JUnit 5@Testmethods, run viamvn test(Surefire's standard "Tests run: X, Failures: 0" output). Previously, if the first check threw, everything after it in main() silently never ran — now each check is isolated.--enable-native-access=ALL-UNNAMEDmoved from ajavacommand-line flag to Surefire'sargLine.Durationcolumn to the results table (from the Actions API'sstarted_at/completed_at), so slow legs are visible without opening each job.Test plan
Tests run: 16, Failures: 0, Errors: 0, Skipped: 0/BUILD SUCCESS