fix(logs): tag skipped conversions as savings:skip(reason) - #38
Open
diegosouzapw wants to merge 1 commit into
Open
fix(logs): tag skipped conversions as savings:skip(reason)#38diegosouzapw wants to merge 1 commit into
diegosouzapw wants to merge 1 commit into
Conversation
…uest line The console request line printed a bare reason word when a request was not converted; tag it as savings:skip(<reason>) so skip reasons are greppable in omniglyph stdout and wrangler tail. Extracted to a pure skipReasonTag helper shared by the Node and Worker hosts (unit-tested). Co-authored-by: teamchong <25894545+teamchong@users.noreply.github.com> Inspired-by: teamchong/pxpipe#119
|
❌ The last analysis has failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tags a non-converted request's skip reason as
savings:skip(<reason>)in the console request line (was a bare reason word), so skip reasons are greppable inomniglyphstdout andwrangler tail. Extracted to a pureskipReasonTaghelper shared by the Node and Worker hosts.src/log-tags.ts— new pure helper (unit-tested intests/log-tags.test.ts)src/node.ts,src/worker.ts— use the helper in the request log linepassthroughReasonsin the JSONL event) is unchanged; this only affects the human console line.Full suite 1096/1096; typecheck/lint/build clean.