docs(chain): point chain.data-flow.continuity at where the check actually is - #5
Merged
Conversation
…ally is The note said the invariant was "baked into provin.oss packages/vc ... in credential.go / VerifyChain". Three things were off, and the last one matters: - provin.oss is a Go module with no packages/ directory — every other note in this catalog already writes the path as vc/claim.go, vc/cryptosuite.go; - VerifyChain is in vc/verifier.go, not credential.go; - naming one file collapsed two different things. credential.go STATES the invariant (a doc comment on the credential type); vc/verifier.go:495 ENFORCES it inside Verifier.VerifyChain. A reader following the note to check that the spec is actually implemented needs the second one. A spec note that cannot be followed to the code is the failure mode this catalog exists against, so it is a defect rather than a typo. Both paths verified to resolve against provin.oss main; lint green (242 rules, 0 todo); no other packages/ reference remains in rules/.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chain.data-flow.continuity's note claimed the invariant wasThree things were off, and the last one is the reason this is a defect rather
than a typo:
packages/vcpackages/. Every other note here already writesvc/claim.go,vc/cryptosuite.goVerifyChainincredential.goVerifier.VerifyChainlives invc/verifier.govc/credential.gostates the invariant (doc comment on the credential type);vc/verifier.go:495enforces it (ps.OutputHash != cs.InputHash)A reader following the note to check that the spec is actually implemented needs
the second one. A note that cannot be followed to the code is the failure mode
this catalog exists against.
Test plan
tools/lint.pygreen — 242 rules, 0 todomain(now public)grep -rn 'packages/' rules/is empty: this was the only occurrenceNormative text unchanged —
statement,uses,vectorsandstatusareuntouched; this is the
notesfield only.🤖 Generated with Claude Code