Replace error types with Unrecognized() variant - #29
Draft
MarijnS95 wants to merge 2 commits into
Draft
Conversation
Contributor
Author
|
One more advantage is that because |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As #17 (comment) noticed, only
DrmModifierhas anUnrecognized()variant, which allows more transparently passing around custom or yet-unknown-to-drm-fourcc-rsmodifiers. The same seems to apply toDrmFourccandDrmVendor, where new constants aren't added that infrequently.By having an
Unrecognized()variant users can freely store aDrmFourcc/DrmVendorand pass it around, without treating new values as a failure case.Important
While just fixing up the tests after initially making the change, I did realize that a value of
0is invalid, unlikeDrmModifierwhich has aLINEARvariant. Perhaps this is worth keeping the error parser for, and this change should show that rewriting the original error tests for this became awkward.