R2 adjustments - documentation and glmmTMB defaults - #929
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #928 by correcting the r2() documentation (“generalized” vs “general” linear models) and revising the r2.glmmTMB() defaults for non-mixed glmmTMB models, with added test coverage for additional glmmTMB families.
Changes:
- Update
r2()documentation to refer to “Generalized linear models” (GLMs) for Nagelkerke’s R2. - Refactor
r2.glmmTMB()non-mixed handling to select R2 method based onglmmTMBfamily and default to McFadden’s R2 for otherwise-unhandled families. - Extend tests for non-mixed
glmmTMBmodels to includecompoisandgenpois, and bump the development version.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
R/r2.R |
Refactors r2.glmmTMB() routing logic and updates docs text in roxygen header. |
tests/testthat/test-r2.R |
Adds/adjusts non-mixed glmmTMB test cases (including compois/genpois). |
man/r2.Rd |
Regenerates docs to match the “Generalized linear models” correction. |
DESCRIPTION |
Bumps package version to reflect user-visible behavioral changes. |
Files not reviewed (1)
- man/r2.Rd: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #928