New function to calculate median odds ratio - #939
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds new performance metrics for mixed (multilevel) logistic regression models—most notably a Median Odds Ratio (MOR) helper—along with supporting exports, documentation, and tests.
Changes:
- Added
performance_mor()(Median Odds Ratio) with an S3 print method and test coverage. - Added
performance_ior()(Interval Odds Ratio) with an S3 print method and exports. - Updated various docs/tests/metadata (ROC test formatting,
anova()link target, NAMESPACE formatting, package version bump).
Reviewed changes
Copilot reviewed 7 out of 11 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/testthat/test-performance_roc.R | Reformats expected ROC vectors and renames test blocks. |
| tests/testthat/test-performance_mor.R | Adds tests for performance_mor() and its error handling. |
| R/test_performance.R | Fixes roxygen link target for stats::anova. |
| R/performance_mor.R | Introduces performance_mor() + print method and roxygen docs. |
| R/performance_ior.R | Introduces performance_ior() + print method and roxygen docs. |
| NAMESPACE | Exports MOR/IOR and registers print S3 methods; reformats imports. |
| man/test_performance.Rd | Regenerated Rd reflecting stats::anova link target change. |
| man/performance_mor.Rd | New generated documentation for MOR. |
| man/performance_ior.Rd | New generated documentation for IOR. |
| man/check_heteroscedasticity.Rd | Minor doc reflow; contains a remaining typo in changed text. |
| DESCRIPTION | Bumps package version and roxygen2 metadata version. |
Files not reviewed (4)
- man/check_heteroscedasticity.Rd: Generated file
- man/performance_ior.Rd: Generated file
- man/performance_mor.Rd: Generated file
- man/test_performance.Rd: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.