feat: add frontend-app-enterprise-checkout to transifex config - #299
feat: add frontend-app-enterprise-checkout to transifex config#299ssrijaindukuri-sonata wants to merge 1 commit into
Conversation
|
✅ All This comment has been posted by the |
|
✅ All This comment has been posted by the |
There was a problem hiding this comment.
Pull request overview
Adds a new Transifex resource entry for frontend-app-enterprise-checkout so that this repository can track and manage its JSON translation files via the existing transifex.yml configuration.
Changes:
- Add a
KEYVALUEJSONTransifex mapping forfrontend-app-enterprise-checkout(source file + translated messages path).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| # frontend-app-enterprise-checkout | ||
| - filter_type: file | ||
| file_format: KEYVALUEJSON | ||
| source_language: en | ||
| source_file: translations/frontend-app-enterprise-checkout/src/i18n/transifex_input.json | ||
| mode: onlyreviewed | ||
| translation_files_expression: 'translations/frontend-app-enterprise-checkout/src/i18n/messages/<lang>.json' |
There was a problem hiding this comment.
This is expected for a new-repo bootstrap entry, not a bug — source_file and
translation_files_expression aren't required to exist in this repo yet. transifex_input.json
gets generated and pushed by frontend-app-enterprise-checkout's own CI when it runs
make extract_translations; the messages/<lang>.json files get written back here by the
Transifex sync job once translations are reviewed. Every other frontend-app-* entry in this
file followed the same pattern when it was first onboarded, so this won't break sync/CI.
The one real prerequisite — making sure the source strings actually extract cleanly — is handled
in a companion PR: frontend-app-enterprise-checkout#228 fixes a defineMessages bug that was
silently hiding two strings from the extractor. That should merge before or alongside this one;
this config itself is safe to merge on its own.
Summary
Part of ENT-11885 ([FE] internationalize
frontend-app-enterprise-checkout). Registers
frontend-app-enterprise-checkoutwith Transifex so itssource strings start being tracked and translated.
Without this entry, Transifex has no resource configured for this app — extracted strings from
transifex_input.jsonwould have nowhere to be pushed to, and there'd be no path for translated<lang>.jsonfiles to be pulled back into via Atlas.Changes
transifex.yml: added afrontend-app-enterprise-checkoutentry, alphabetized with the rest ofthe
frontend-app-*block, following the same schema (filter_type: file,KEYVALUEJSON,mode: onlyreviewed) used by every neighboring MFE.source_file:translations/frontend-app-enterprise-checkout/src/i18n/transifex_input.jsontranslation_files_expression:translations/frontend-app-enterprise-checkout/src/i18n/messages/<lang>.jsonThis path matches exactly what the app's
Makefilealready expects in itsatlas pullmapping(see frontend-app-enterprise-checkout#228).
Related