mspm0: new adc driver#6546
Open
i509VCB wants to merge 2 commits into
Open
Conversation
i509VCB
commented
Jul 18, 2026
| impl<'d, T: Instance, M: Mode> Adc<'d, T, M> { | ||
| const SINGLE_CHANNEL: u8 = 0; | ||
| /// Read an ADC pin. | ||
| pub fn blocking_read<'a>(&mut self, channel: impl BorrowedChannel<'a, T>, conversion: Conversion) -> u16 |
Member
Author
There was a problem hiding this comment.
One thing I should check again is why I need to clarify lifetimes here but stm32 has no such additional bounds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be more similar to stm32.
Some new additions too which involved some larger changes to the driver.