Skip to content

Redo plumbing for device arch and use semconv attribute name - #3551

Open
bidetofevil wants to merge 1 commit into
EMBR-12879/hho/rename-distrofrom
EMBR-12880/hho/use-arch-sem-conv
Open

Redo plumbing for device arch and use semconv attribute name#3551
bidetofevil wants to merge 1 commit into
EMBR-12879/hho/rename-distrofrom
EMBR-12880/hho/use-arch-sem-conv

Conversation

@bidetofevil

@bidetofevil bidetofevil commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Use the semantic convention-defined host.arch attribute name instead of the bespoke device_architecture in the envelope resource

bidetofevil commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

@codecov

codecov Bot commented Jul 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 78.42%. Comparing base (acd9c86) to head (89ccbfa).

Files with missing lines Patch % Lines
.../embrace/android/embracesdk/internal/SystemInfo.kt 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@                       Coverage Diff                        @@
##           EMBR-12879/hho/rename-distro    #3551      +/-   ##
================================================================
- Coverage                         78.45%   78.42%   -0.03%     
================================================================
  Files                               631      631              
  Lines                             13652    13652              
  Branches                           2120     2121       +1     
================================================================
- Hits                              10710    10706       -4     
- Misses                             2137     2138       +1     
- Partials                            805      808       +3     
Files with missing lines Coverage Δ
...id/embracesdk/internal/config/ConfigServiceImpl.kt 92.47% <100.00%> (ø)
...brace/android/embracesdk/internal/config/CpuAbi.kt 100.00% <100.00%> (ø)
...al/envelope/resource/EnvelopeResourceSourceImpl.kt 95.34% <ø> (-0.11%) ⬇️
...d/embracesdk/internal/otel/config/OtelSdkConfig.kt 98.63% <100.00%> (+0.01%) ⬆️
...cesdk/internal/injection/ModuleInitBootstrapper.kt 97.51% <100.00%> (ø)
.../embrace/android/embracesdk/internal/SystemInfo.kt 70.58% <66.66%> (-0.38%) ⬇️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lemnik lemnik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bidetofevil
bidetofevil force-pushed the EMBR-12879/hho/rename-distro branch from a1953b9 to a56f805 Compare July 6, 2026 20:37
@bidetofevil
bidetofevil force-pushed the EMBR-12880/hho/use-arch-sem-conv branch from 4f7dac6 to 5230f23 Compare July 6, 2026 20:37
@bidetofevil
bidetofevil force-pushed the EMBR-12880/hho/use-arch-sem-conv branch from 5230f23 to 79b48e4 Compare July 6, 2026 21:43
@bidetofevil
bidetofevil force-pushed the EMBR-12879/hho/rename-distro branch from a56f805 to 5cccd4d Compare July 6, 2026 21:43

@fractalwrench fractalwrench left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bidetofevil
bidetofevil force-pushed the EMBR-12880/hho/use-arch-sem-conv branch from 79b48e4 to ca5c487 Compare July 7, 2026 21:22
@bidetofevil
bidetofevil force-pushed the EMBR-12879/hho/rename-distro branch from 5cccd4d to 2b2cd34 Compare July 7, 2026 21:22
@bidetofevil
bidetofevil force-pushed the EMBR-12879/hho/rename-distro branch from 2b2cd34 to 2b6fc7d Compare July 8, 2026 19:55
@bidetofevil
bidetofevil force-pushed the EMBR-12880/hho/use-arch-sem-conv branch from ca5c487 to dfeefc1 Compare July 8, 2026 19:55
@bidetofevil
bidetofevil force-pushed the EMBR-12879/hho/rename-distro branch from 2b6fc7d to d55431b Compare July 13, 2026 18:07
@bidetofevil
bidetofevil force-pushed the EMBR-12880/hho/use-arch-sem-conv branch from dfeefc1 to 44fae01 Compare July 13, 2026 18:07
@bidetofevil
bidetofevil force-pushed the EMBR-12880/hho/use-arch-sem-conv branch from 44fae01 to ecd1ee8 Compare July 20, 2026 20:25
@bidetofevil
bidetofevil force-pushed the EMBR-12879/hho/rename-distro branch 2 times, most recently from 145a2f5 to acd9c86 Compare July 24, 2026 17:10
@bidetofevil
bidetofevil force-pushed the EMBR-12880/hho/use-arch-sem-conv branch from ecd1ee8 to 89ccbfa Compare July 24, 2026 17:11
@bidetofevil
bidetofevil force-pushed the EMBR-12880/hho/use-arch-sem-conv branch from 89ccbfa to 16d5c4e Compare July 27, 2026 22:10
@bidetofevil
bidetofevil force-pushed the EMBR-12879/hho/rename-distro branch from acd9c86 to 3b0de9a Compare July 27, 2026 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants