server: add workload-adaptive auto-periodic compaction mode#22095
server: add workload-adaptive auto-periodic compaction mode#22095evanphx wants to merge 1 commit into
Conversation
Add a third --auto-compaction-mode, "auto-periodic", alongside "periodic" and "revision". Rather than a fixed schedule, it samples the backend's growth rate and times each compaction so the projected size stays below a fraction of --quota-backend-bytes, adapting to the workload: faster growth compacts sooner (more headroom exactly when needed), an idle store backs off. It keeps the last --auto-compaction-retention revisions, like the revision mode. Like the periodic and revision modes it only compacts and never defrags, so reclaiming physical disk space remains a separate, operator-initiated operation. The mode needs the backend size and the effective quota, so v3compactor.New gains a SizeGetter and a maxBytes argument; the periodic and revision compactors ignore them. Signed-off-by: Evan Phoenix <evan@miren.dev> Claude-Session: https://claude.ai/code/session_0149GYz8NL7YY3jBfubXJZJQ Signed-off-by: Evan Phoenix <evan@phx.io>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: evanphx The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @evanphx. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Add a third --auto-compaction-mode, "auto-periodic", alongside "periodic" and "revision". Rather than a fixed schedule, it samples the backend's growth rate and times each compaction so the projected size stays below a fraction of --quota-backend-bytes, adapting to the workload: faster growth compacts sooner (more headroom exactly when needed), an idle store backs off. It keeps the last --auto-compaction-retention revisions, like the revision mode.
Like the periodic and revision modes it only compacts and never defrags, so reclaiming physical disk space remains a separate, operator-initiated operation.
The mode needs the backend size and the effective quota, so v3compactor.New gains a SizeGetter and a maxBytes argument; the periodic and revision compactors ignore them.
This change was written with the assistance of Claude.