Fix local geth dev script and EIP-7702 test gas limit - #625
Open
witchinghourartcollective wants to merge 1 commit into
Open
Conversation
Quote --http.corsdomain/--http.vhosts wildcards in scripts/geth.sh so bash doesn't glob-expand them to repo filenames before reaching docker run. Bump verificationGasLimit in the EIP-7702 entrypoint test so the delegate-init flow doesn't run out of gas.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/geth.sh: quote the--http.corsdomain/--http.vhostswildcards so bash doesn't glob-expand*to filenames in the repo root before they reachdocker run(this was breaking the local geth dev container — it would receive repo filenames likeREADME.mdas bogus args and fail to start).test/entrypoint-7702.test.ts: set an explicitverificationGasLimit: 300000on the "should fail without sender delegate" case — the default150000isn't enough for the delegate-init flow.Test plan
yarn test— 146/146 passing, including the geth-integration EIP-7702 cases