cmd/devp2p: fix leftover request id error message#35377
Closed
0xoasis wants to merge 1 commit into
Closed
Conversation
Align the eth/70 large-receipts test failure message with the wording and argument order used by the other GetReceipts checks from ethereum#35138.
Contributor
|
I've considered merging this but I also don't think we have enough capacity to review changes like this (fix for error message, especially about typo and style) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#35138 fixed several "unexpected request id in respond" messages in the eth protocol tests, but left one behind in
TestGetLargeReceipts. Align the remaining failure message with the wording andgot/wantargument order used by the other GetReceipts checks.Test plan
go build ./cmd/devp2p/