Fix Rails 7+ mutating forum actions by replacing method links with button forms - #42
Merged
Merged
Conversation
Replace JS-dependent usages in discussion views with so post/delete/put actions work without rails-ujs (issue excid3#41). Add a regression test covering forum post and notification templates to ensure these mutating actions stay non-JS form submissions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Mutating forum actions relied on
link_to ... method:(delete post, mark solved/unsolved, notification toggle). In Rails 7+ setups without rails-ujs, these links fall back to GET and the intended POST/PUT/DELETE actions do not execute.Root Cause
link_towithmethod:depends on JavaScript interception viadata-method.Fix
link_to ... method:calls withbutton_toin:Tests
test/views/non_js_actions_test.rbto assert these mutating actions usebutton_toand no longer uselink_to ... method:.bundle _2.7.1_ exec ruby test/views/non_js_actions_test.rbbundle _2.7.1_ exec standardrb test/views/non_js_actions_test.rbFixes #41