Error if working directory or environmet script nonexistent or unreadable - #15
Open
nathanweeks wants to merge 1 commit into
Open
Error if working directory or environmet script nonexistent or unreadable#15nathanweeks wants to merge 1 commit into
nathanweeks wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the user-specified working directory or environment script file do not exist or are not readable, explicitly exit with a non-zero exit status.
These tests / fast failures must be done in before.sh.erb, as script.sh.erb exiting with an error before a process listens on the specified port apparently still results in a "hang" as OOD waits for a listener on the port. The recently-increased wait time will can (has) caused this situation to be mistaken for a filesystem-hang-induced timeout.