render markdown body only on request - #177
Open
karthik2804 wants to merge 2 commits into
Open
Conversation
Signed-off-by: karthik2804 <karthik.ganeshram@fermyon.com>
karthik2804
force-pushed
the
index_conditional_rendering
branch
from
July 15, 2023 00:05
ffc403d to
52c3341
Compare
tschneidereit
left a comment
tschneidereit
left a comment
There was a problem hiding this comment.
Looks good to me, but I would prefer someone with more knowledge of the system sign off on this
Signed-off-by: karthik2804 <karthik.ganeshram@fermyon.com>
karthik2804
force-pushed
the
index_conditional_rendering
branch
from
July 15, 2023 00:21
3c6c04a to
449fa08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new handlebars helper
render_markdown.This helper allows us to conditionally render the markdown in the body which helps with rendering performance as we currently render the entire set of pages when indexed on each rendering.
This would be a breaking change wherein occurrences of
would need to be replaced by