Fix Unicode::BiDiRule CPAN support with ICU4J - #910
Merged
Conversation
Replace the Unicode::BiDiRule XS surface with an ICU4J-backed RFC 5893 implementation. Add the missing Unicode::UCD::UnicodeVersion method needed by the distribution's configure and test phases. Generated with [OpenAI Codex](https://openai.com/codex/) Co-Authored-By: OpenAI Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unicode::BiDiRuleXS API in Java using the existing ICU4J dependencyUnicode::UCD::UnicodeVersiontooling dependencyLingua::EN::Phonemeis intentionally not patched: its published tarball omitsinc/Module/Install.pm, so itsMakefile.PLfails the same way under system Perl and is excluded under the requested compatibility criterion.Validation
make— passedtimeout 900 ./jcpan -t Unicode::BiDiRule— passed (30 tests)Lingua::EN::Phonemeconfiguration — fails before testing becauseinc/Module/Install.pmis absent from the upstream tarballGenerated with OpenAI Codex.