Complete ICU-backed regex case folds - #912
Merged
Merged
Conversation
Use the full ICU casemapped candidate set, supplement simple folds missing from Java Pattern's Unicode tables, and include sibling code points sharing the same full fold. Generated with [Codex](https://developers.openai.com/codex/) Co-Authored-By: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes_When_Casemappedproperty as the complete, bounded candidate set for full foldsPatternUnicode tables do notResults versus merged PR #911
re/reg_fold.tre/fold_grind_u.tre/fold_grind_d.tre/fold_grind_a.tre/fold_grind_aa.top/ref.tThe grind tests suppress successful internal subtests but emit each failure, so lower denominators represent additional passing internal cases.
Validation
make— passed, all unit shards (2m36s)prove src/test/resources/unit/regex_icu_full_casefold.t— 6/6 passedperl_test_runner.plcomparison — no fold timeouts or incomplete fold files