fix(docker): bump builder image to golang:1.26.4-alpine - #35
Merged
Conversation
The Docker build was still on golang:1.25.9-alpine while go.mod requires go >= 1.26.4. With GOTOOLCHAIN=local the builder refuses to auto-upgrade, so `go mod download` fails: go: go.mod requires go >= 1.26.4 (running go 1.25.9; GOTOOLCHAIN=local) The toolchain bump in #32 updated go.mod and the setup-go workflow pins but missed the Dockerfile (its base was 1.25.9, not the 1.25.10 the sed targeted), so the Build & Push Docker job broke. This realigns the image with the rest of the toolchain. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
Build & Push Dockerjob fails onmain:Cause
The toolchain bump in #32 updated
go.mod(go 1.26.4) and thesetup-gopins in the workflows, but the Dockerfile base image stayed atgolang:1.25.9-alpine. Thesedin that PR targetedgolang:1.25.10-alpine(assuming #28 had bumped it), but the Dockerfile was actually still1.25.9, so it was left behind. UnderGOTOOLCHAIN=localthe image refuses to auto-upgrade, breakinggo mod download.Fix
Bump the builder base image to
golang:1.26.4-alpine, matchinggo.modand the workflowgo-versionpins. The other jobs (Build & Test, Lint, Security Scan) already pass because they useactions/setup-go@v6withgo-version: '1.26.4'.🤖 Generated with Claude Code