Skip to content
This repository was archived by the owner on Jan 20, 2026. It is now read-only.

Filter out problematic ticket_chat_event records - #72

Merged
fivetran-jamie merged 2 commits into
mainfrom
bugfix/ticket-chat-event-actor
Jul 2, 2025
Merged

Filter out problematic ticket_chat_event records#72
fivetran-jamie merged 2 commits into
mainfrom
bugfix/ticket-chat-event-actor

Conversation

@fivetran-jamie

@fivetran-jamie fivetran-jamie commented Jul 1, 2025

Copy link
Copy Markdown
Contributor

PR Overview

Package version introduced in this PR:
v0.18.1

This PR addresses the following Issue/Feature(s):

GA-979454

Summary of changes:

Excludes records from ticket_chat_event in which the actor_id is __trigger or __system to successfully parse out and cast actor_id as an integer for downstream user_id-based joins. These message events are also not pertinent to downstream ticket comment metrics.

Submission Checklist

  • Alignment meeting with the reviewer (if needed)
    • Timeline and validation requirements discussed
  • Provide validation details:
    • Validation Steps:

Ran validation tests from transform package pointing to this
image
image

  • Testing Instructions: Confirm the change addresses the issue(s)

Adjusted seed data to include problematic actor_id values (__trigger and __system). When I run prod code on this seed, I get the following error
image

With my updates, I see a successful run (will share screenshots in Height). I also ran on customer's WH and saw the same behavior.

  • Focus Areas: Complex logic or queries that need extra attention

Changelog

  • Draft changelog for PR
  • Final changelog for release review

@fivetran-jamie fivetran-jamie changed the title stage Filter out problematic ticket_chat_event records Jul 1, 2025
@fivetran-joemarkiewicz
fivetran-joemarkiewicz self-requested a review July 1, 2025 21:19
@fivetran-jamie
fivetran-jamie marked this pull request as ready for review July 1, 2025 21:21

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fivetran-catfritz fivetran-catfritz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@fivetran-jamie
fivetran-jamie merged commit b603a3b into main Jul 2, 2025
8 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants