Skip to content

[1.x] ci(core): allow pnpm to be used as package manager - #4910

Open
DavideIadeluca wants to merge 1 commit into
flarum:1.xfrom
glowingblue:di/pnpm-support
Open

[1.x] ci(core): allow pnpm to be used as package manager#4910
DavideIadeluca wants to merge 1 commit into
flarum:1.xfrom
glowingblue:di/pnpm-support

Conversation

@DavideIadeluca

@DavideIadeluca DavideIadeluca commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

1.x equivalent to #4911

Fixes #0000
flarum/action-build has support for using pnpm as the package manager since many years, however the reusable frontend workflow never added full support for it.

Changes proposed in this pull request:

  • Adds a additional CI step which installs pnpm if it's the provided package manager
  • Bumps node because the latest pnpm version requires node version 22 or newer
  • Bumps actions/setup-node to further get rid of some warnings

Reviewers should focus on:

Screenshot

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)

@DavideIadeluca
DavideIadeluca marked this pull request as ready for review August 6, 2026 14:59
@DavideIadeluca
DavideIadeluca requested a review from a team as a code owner August 6, 2026 14:59
@DavideIadeluca

Copy link
Copy Markdown
Contributor Author

@imorland To get green CI here, can you please manually re run just Statistics PHP / run / PHP 8.4 / MariaDB (pull_request) and Statistics PHP / run / PHP 8.0 / MariaDB (pull_request)? It seems like that Docker Hub is rejecting pulls towards the end of the CI run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant