Sshpiper support - #13
Open
gi-yt wants to merge 29 commits into
Open
Conversation
Contributor
Author
|
@adityahase scp and sftp works. codeserver is a bit iffy (but from what i understood, thats because of the dev setup lag, not sshpiperd itself) |
This reverts commit 7d5f8cf.
Contributor
Confidence Score: 4/5The core implementation is solid, but two unresolved merge conflict markers corrupt spec documents and should be cleaned before merge. The SSH transport, gateway configuration, and lookup authentication logic are well-structured and tested. Two raw conflict markers left in spec files break the documents and are the primary blocker. spec/03-bootstrapping.md and spec/README.md contain unresolved merge conflict markers; atlas/atlas/sshpiper.py has the URL-parameter token issue. Reviews (2): Last reviewed commit: "Update spec/03-bootstrapping.md" | Re-trigger Greptile |
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds SSHPiper as the public SSH ingress path for Atlas VMs.
refer to spec/23-sshpiper.md for more details
breaking changes: