fix: resolve text block bubble menu color picker positioning, slider drag, and popup layout - #694
fix: resolve text block bubble menu color picker positioning, slider drag, and popup layout#694SmrutiSawant wants to merge 5 commits into
Conversation
Confidence Score: 4/5The core positioning and drag fixes look correct, but the shouldShow guard can still dismiss the color picker if selection collapses while it is open. The shouldShow function places settingColor.value after an early return that fires when there is no text selection. A collapsed selection while the picker is open still closes the bubble menu, meaning the slider-drag fix is not fully robust. frontend/src/components/TextBlockBubbleMenu.vue — the shouldShow callback ordering Reviews (3): Last reviewed commit: "Update frontend/src/components/TextBlock..." | Re-trigger Greptile |
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #694 +/- ##
========================================
Coverage 56.88% 56.88%
========================================
Files 35 35
Lines 4217 4217
========================================
Hits 2399 2399
Misses 1818 1818 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
The main issue was that the The |
Summary of Changes
Fixes positioning and interaction issues with the text editor's
TextBlockBubbleMenucolor picker:Before:
Before.mp4
After:
After.mp4