Skip to content

feat: add translation foundation - #706

Open
mardausdennis wants to merge 2 commits into
frappe:developfrom
mardausdennis:feat/builder-i18n-foundation
Open

feat: add translation foundation#706
mardausdennis wants to merge 2 commits into
frappe:developfrom
mardausdennis:feat/builder-i18n-foundation

Conversation

@mardausdennis

Copy link
Copy Markdown

Summary

  • add an authenticated GET-only endpoint for the current user's Frappe translations
  • load translations before Builder's initial router navigation, with English error and timeout fallback
  • localize representative Builder strings and register TypeScript extraction

Validation

  • 11 translation helper tests
  • 6 Frappe integration tests, including endpoint authorization and canonical catalog locations
  • Linux production build with Node 24 and Vite 5.4
  • 3 Cypress startup/error/timeout scenarios on a disposable Frappe site

- load authenticated Frappe translations before the initial router navigation
- add fallback, timeout, extraction, endpoint, and browser coverage
@greptile-apps

greptile-apps Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 5/5

The PR appears safe to merge.

The previously reported bootstrap failure is fixed; no blocking failure remains.

Reviews (2): Last reviewed commit: "fix: preserve translation fallback witho..." | Re-trigger Greptile

Comment thread frontend/src/translation.ts Outdated
@mardausdennis

Copy link
Copy Markdown
Author

@surajshetty3416 The implementation and follow-up review fix are ready. Greptile is 5/5 and the addressed thread is resolved. Linters, UI Test, and Server Tests are currently action_required with 0 jobs executed, so they still need maintainer approval to run. Could you approve the workflows and review the PR when convenient?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant