feat: add translation foundation - #706
Open
mardausdennis wants to merge 2 commits into
Open
Conversation
- load authenticated Frappe translations before the initial router navigation - add fallback, timeout, extraction, endpoint, and browser coverage
Contributor
Confidence Score: 5/5The PR appears safe to merge. The previously reported bootstrap failure is fixed; no blocking failure remains. Reviews (2): Last reviewed commit: "fix: preserve translation fallback witho..." | Re-trigger Greptile |
Author
|
@surajshetty3416 The implementation and follow-up review fix are ready. Greptile is 5/5 and the addressed thread is resolved. Linters, UI Test, and Server Tests are currently |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation