Skip to content

fix: Design Tokens naming and escaping a pending token row - #707

Merged
surajshetty3416 merged 2 commits into
frappe:developfrom
surajshetty3416:token-manager-fixes
Aug 3, 2026
Merged

fix: Design Tokens naming and escaping a pending token row#707
surajshetty3416 merged 2 commits into
frappe:developfrom
surajshetty3416:token-manager-fixes

Conversation

@surajshetty3416

@surajshetty3416 surajshetty3416 commented Aug 3, 2026

Copy link
Copy Markdown
Member

Follow-ups on #676.

  • The colour field's action button still read Save as Variable → now Save as Token.
  • The panel is called Design Tokens (header and the left sidebar tooltip), not Design System.
  • Escape only discarded a pending new row while the name cell had focus, so pressing it from the value cells left an empty row behind. It is handled on the row now, from any cell.

Escape only discarded the new row from its name cell, so pressing it
anywhere else in the row left an empty row behind. Handle it on the row.

The panel is called Design Tokens now, and the colour field's action
still said 'Save as Variable'.
@greptile-apps

greptile-apps Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Reviews (2): Last reviewed commit: "fix: hold the token list open on an empt..." | Re-trigger Greptile

Switching to a tab with no tokens, or adding the first one, shrank the
whole panel to the height of a single row.
@codecov

codecov Bot commented Aug 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.59%. Comparing base (c60696f) to head (9636ba8).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #707   +/-   ##
========================================
  Coverage    59.59%   59.59%           
========================================
  Files           35       35           
  Lines         4413     4413           
========================================
  Hits          2630     2630           
  Misses        1783     1783           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@surajshetty3416
surajshetty3416 merged commit d6b7d02 into frappe:develop Aug 3, 2026
10 of 11 checks passed
@surajshetty3416
surajshetty3416 deleted the token-manager-fixes branch August 3, 2026 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant