fix: Design Tokens naming and escaping a pending token row - #707
Merged
surajshetty3416 merged 2 commits intoAug 3, 2026
Conversation
Escape only discarded the new row from its name cell, so pressing it anywhere else in the row left an empty row behind. Handle it on the row. The panel is called Design Tokens now, and the colour field's action still said 'Save as Variable'.
Contributor
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Reviews (2): Last reviewed commit: "fix: hold the token list open on an empt..." | Re-trigger Greptile |
Switching to a tab with no tokens, or adding the first one, shrank the whole panel to the height of a single row.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #707 +/- ##
========================================
Coverage 59.59% 59.59%
========================================
Files 35 35
Lines 4413 4413
========================================
Hits 2630 2630
Misses 1783 1783 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups on #676.