Skip to content

make x and y axis labels show - #1135

Open
khoran wants to merge 2 commits into
frappe:developfrom
galcom:develop
Open

make x and y axis labels show#1135
khoran wants to merge 2 commits into
frappe:developfrom
galcom:develop

Conversation

@khoran

@khoran khoran commented May 25, 2026

Copy link
Copy Markdown

Fix for #593. X and Y axis labels now show in V3 charts when the label is enable and text is entered.

@nextchamp-saqib

Copy link
Copy Markdown
Member

Hi, can you explain the problem and also the solution with examples?

@khoran

khoran commented May 26, 2026

Copy link
Copy Markdown
Author

There is a picture on #593. Basically, when I enable the x or y axis toggles and then enter a label, nothing shows up on either axis. I tested this with the version-3 branch and the develop branch. Since I found that existing issue also, I assumed it wasn't just affecting me. One difference from the picture in #593 is that there is no label in the corner, as shown in that image. I'm not sure what that label would be for or where it would have been entered from. So just ignore that part for the purpose of this PR.

This PR makes it so that the label text appears for both the x and y axis when enabled.

@mergify

mergify Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants