fix: resolve build warnings and vulnerable transitive package versions - #33
Merged
Conversation
- Suppress FS0044 self-calls in deprecated schema-processor types and drop redundant upcasts (FS0066) in JsonSchema.fs - Pin System.Text.Json and Newtonsoft.Json above versions flagged by NU1903 (GHSA-8g4q-xg66-9fp4, GHSA-5crp-9r3c-p9vr) - Bump Expecto to 9.0.4 to clear the NU1605 downgrade warning against Verify.Expecto's floor - Bump Microsoft.NET.Test.Sdk 16.8.0 -> 17.14.1 across test projects, removing its vulnerable transitive Newtonsoft.Json 9.0.1 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Marking each interface-impl member [<Obsolete>] doesn't suppress the warning for calling another Obsolete member in F# (unlike C#'s CS0618 behavior) - verified it still fired at all 5 sites. Use line-scoped #nowarn/#warnon "44" pragmas instead, bounded to each call, so unrelated future obsolete-API misuse in this file still warns. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#nowarn/#warnon "44"pragmas around each of the 5 sites where a deprecated processor type's member calls its own (also deprecated) member - not a blanket file-level suppression, so unrelated future obsolete-API misuse in this file still warnsKnown tradeoffs
Test plan
dotnet build FSharp.Data.JsonSchema.sln— zero warnings besides pre-existing NETSDK1188 locale noisedotnet test FSharp.Data.JsonSchema.sln— 573/573 passing across net8.0/net9.0/net10.0🤖 Generated with Claude Code